Automated Tests with PHPUnit

I think there is an error with one of the tests - I think the assertDatabaseCount should be set to 0

   public function testUserCanDeleteTheirVehicle()
   {
       $user = User::factory()->create();
       $vehicle = Vehicle::factory()->create(['user_id' => $user->id]);
 
       $response = $this->actingAs($user)->deleteJson('/api/v1/vehicles/' . $vehicle->id);
 
       $response->assertNoContent();
 
       $this->assertDatabaseMissing('vehicles', [
           'id' => $vehicle->id,
           'deleted_at' => NULL
       ])->assertDatabaseCount('vehicles', 1);
   }

Last one I promise :)

I didn't seem to get all 3 tests running - they only seemed to all work when I made the following changes to the ParkingResource.php - can you confirm if I have done something wrong? I basically used a check to see if it was an instance of Carbon and format the date to Y-m-d H:i:s.

public function toArray($request)
{
    $totalPrice = $this->total_price ?? ParkingPriceService::calculatePrice(
        $this->zone_id,
        $this->start_time,
        $this->stop_time
    );
 
    $startDate = $this->start_time ?? null;
    $stopDate = $this->stop_time ?? null;
    $parkingDurationInSecs = ($stopDate) ? $startDate->diffInSeconds($stopDate) : 0;
 
    if ($startDate instanceof Carbon) {
        $startDate = $this->start_time->format('Y-m-d H:i:s');
    }
 
    if ($stopDate instanceof Carbon) {
        $stopDate = $this->stop_time->format('Y-m-d H:i:s');
    }
 
    return [
        'id' => $this->id,
        'zone' => [
            'name' => $this->zone->name,
            'price_per_hour' => $this->zone->price_per_hour,
        ],
        'vehicle' => [
            'reg_number' => $this->vehicle->reg_number,
        ],
        'start_time' => $startDate,
        'stop_time' => $stopDate,
        'total_price' => $totalPrice,
        'parking_duration_seconds' => $parkingDurationInSecs,
    ];
}

I pushed the repo here if that helps https://github.com/gkimpson/car-parking-api

under testUserCanStopParking(), i have to edit my code from this:

$response->assertStatus(200)
        ->assertJsonStructure(['data'])
        ->assertJson([
            'data' => [
                'start_time'  => $updatedParking->start_time->toDateTimeString(),
                'stop_time'   => $updatedParking->stop_time->toDateTimeString(),
                'total_price' => $updatedParking->total_price,
            ],
        ]);

to this:

$response->assertStatus(200)
        ->assertJsonStructure(['data'])
        ->assertJson([
            'data' => [
                'start_time'  => $updatedParking->start_time->format('Y-m-d\TH:i:s.u\Z'),
                'stop_time'   => $updatedParking->stop_time->format('Y-m-d\TH:i:s.u\Z'),
                'total_price' => $updatedParking->total_price,
            ],
        ]);

otherwise, it returns an error because using toDateTimeString() on start_time and stop_time does not return fractional seconds ('.000000Z'). so to fix this, i used format('Y-m-d\TH:i:s.u\Z').

I also did the 'homework' tasks - so anybody that hasn't done this yet and wants to do so without any tips please look away now :)

Povilas - would the tests below appear to look like valid tests for you, if not how would you modify them to make them better?

ProfileTest.php

public function testUserCannotUpdatePasswordWithNonMatchingPassword()
{
    $user = User::factory()->create();
 
    $response = $this->actingAs($user)->putJson('/api/v1/password', [
        'current_password' => 'password',
        'password' => 'testing123',
        'password_confirmation' => 'incorrectpassword',
    ]);
 
    $response
        ->assertStatus(422)
        ->assertJson([
            'message' => 'The password confirmation does not match.',
        ]);
}
 
public function testUnauthenticatedUserCannotAccessProfile()
{
    $user = User::factory()->create();
    $response = $this->actingAs($user);
    Auth::logout();
    $response = $this->getJson('/api/v1/profile');
            $this->assertGuest();
 
    $response
        ->assertStatus(401)
        ->assertJson([
            'message' => 'Unauthenticated.',
        ]);
}

Hello, There is a problem in the UserCanDeleteTheirVehicle test because this model uses SoftDeletes, so the record is not deleted, that way, when you do assertDatabaseCount('vehicles', 0), it displays the error, because the count of the table is 1 and the comparative is 0. In the controller I switched to using forceDelete and then the test passed. Did I make a mistake, or did I misunderstand something?